Project

General

Profile

Bug #11006

filetostring.cmake generates file literals that exceed the minimum maximum string literal length

Added by Roel Standaert about 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
High
Target version:
Start date:
10/13/2022
Due date:
% Done:

100%

Estimated time:

Description

The C++ standard sets the minimum maximum string literal length to 65536 characters: https://timsong-cpp.github.io/cppwp/n4140/implimits#2.15

Some compilers actually have this maximum, like the VS2017 compiler. Other compilers, like clang, will produce a -Woverlength-strings warning.

In order to comply with the standard, we could change our filetostring code to e.g. output an array of hex characters instead of using a string literal.


Related issues

Related to Improvements #8629: Change JavaScript minifierResolvedRoel Standaert06/03/2021

Actions
Related to Bug #10941: [MSVC] Wt failed to build with error C2026 on MSVCResolvedRoel Standaert09/14/2022

Actions
#1

Updated by Roel Standaert about 2 months ago

#2

Updated by Roel Standaert about 2 months ago

  • Related to Bug #10941: [MSVC] Wt failed to build with error C2026 on MSVC added
#3

Updated by Roel Standaert about 2 months ago

  • Status changed from New to InProgress
#4

Updated by Roel Standaert about 2 months ago

  • Status changed from InProgress to Review
  • Assignee changed from Roel Standaert to Korneel Dumon
#5

Updated by Roel Standaert about 1 month ago

  • Priority changed from Normal to High

This issue is blocking the 4.9.0 release and must be resolved for release, hence bumping priority up to high.

#6

Updated by Korneel Dumon about 1 month ago

  • Assignee changed from Korneel Dumon to Roel Standaert
#7

Updated by Roel Standaert about 1 month ago

  • Status changed from Review to Implemented @Emweb
  • % Done changed from 0 to 100
#8

Updated by Roel Standaert about 1 month ago

  • Status changed from Implemented @Emweb to Resolved

Also available in: Atom PDF