Project

General

Profile

Bug #1866

Incorrect styling of bootstrap-themed tabs without javascript

Added by Bruce Toll over 8 years ago. Updated about 8 years ago.

Status:
New
Priority:
Low
Assignee:
Target version:
-
Start date:
04/23/2013
Due date:
% Done:

0%

Estimated time:

Description

The tabs in WTabwidgets are not styled correctly when using the bootstrap theme without javascript. This can be seen in the bundled Wt widgetgallery example at relative path widgets/navigation/tab-widget, using the current github version of Wt (3.3.0-7-g53cd144). The text of tabs is displayed --- and clicks on the text function as expected (please see resolved bug #1840, which may be related).


Files

#1

Updated by Koen Deforche over 8 years ago

Bootstrap is confused by the 'button' that we add inbetween the li and a to catch the click event. The CSS needs updating for that, and since we do not modify the bootstrap CSS files, we will need to replicate a number of their style rules... which isn't a nice solution.

One thing that may be interesting to know is that enabling internal paths on the tab widget will resolve this issue since we then use the anchor to relay the click events.

#2

Updated by Bruce Toll over 8 years ago

Thanks, that's helpful.

#3

Updated by Bruce Toll over 8 years ago

Hi Koen,

As a note, I had experimented with a patch that appends a signal parameter to a GET when Javascript is not available (similar to the handling of AREA tags). It seems to work (in my limited testing with your recent git version, 3.3.0-10-g45b859b). Progressive boots are handled by using the unwrap mechanism to disable the anchor href. The patch is attached.

Based on your earlier comment, I will also revisit enabling internal paths.

Regards,

Bruce

#4

Updated by Koen Deforche about 8 years ago

Hey Bruce,

That patch looks good indeed, will be applied, thanks!

Regards,

koen

#5

Updated by Koen Deforche about 8 years ago

  • Status changed from New to Resolved
  • Assignee set to Koen Deforche
  • Target version set to 3.3.1

Hey Bruce,

That patch looks good indeed, will be applied, thanks!

Regards,

koen

#6

Updated by Koen Deforche about 8 years ago

  • Status changed from Resolved to New
  • Target version deleted (3.3.1)

I guess the core problem isn't really solved --- but there is a workaround at least!

Also available in: Atom PDF