Project

General

Profile

Actions

Bug #2763

open

Slow Perfomance on InternetExplorer8 caused by getCssRule

Added by Marco Kinski about 10 years ago. Updated about 10 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
03/06/2014
Due date:
% Done:

0%

Estimated time:

Description

I used the build in profiler and noticed that most of the time when recreating a dialog (composed of WStackedWidgets some WTableView, WTreeViews and Forms) is spent in a function called Wt.js/getCssRule. I placed traces inside this function and found out that half the time it does not find the element its looking for (while recreating the dialog it runs ~120 times with ~900 elements to check against).

Is it possible to reduce the amount that function gets called?

Answer from koen via list:

It seems that indeed we have full knowledge of what is already defined and thus we should not be calling getCssRule() if it the rule does not yet exist.

The function void WCssStyleSheet::ruleModified(WCssRule *rule) is probably not taking into account that a rule is added instead of being modified.


Files

getCssRule.js (1.48 KB) getCssRule.js Marco Kinski, 03/06/2014 06:12 PM
Actions #1

Updated by Marco Kinski about 10 years ago

I changed the getCssRule function so that it is ~10% faster.

Actions

Also available in: Atom PDF