Project

General

Profile

Bug #4455

Can not build WT with SKIA

Added by Momo LALMI over 6 years ago. Updated 27 days ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
09/05/2015
Due date:
% Done:

0%

Estimated time:

Description

Hello,

some Skia functions are deprecated. Please see below VS2013 errors ;

1>  WRasterImage-skia.C
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\Render\WPdfRenderer.C(122): warning C4244: 'argument' : conversion from 'double' to 'HPDF_REAL', possible loss of data
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(91): error C2039: 'setConfig' : is not a member of 'SkBitmap'
1>          C:\DEV\3rd_party_sources\skia\include\core\SkBitmap.h(38) : see declaration of 'SkBitmap'
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(91): error C2039: 'kARGB_8888_Config' : is not a member of 'SkBitmap'
1>          C:\DEV\3rd_party_sources\skia\include\core\SkBitmap.h(38) : see declaration of 'SkBitmap'
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(91): error C2065: 'kARGB_8888_Config' : undeclared identifier
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(257): error C2248: 'SkDashPathEffect::SkDashPathEffect' : cannot access protected member declared in class 'SkDashPathEffect'
1>          C:\DEV\3rd_party_sources\skia\include\effects\SkDashPathEffect.h(62) : see declaration of 'SkDashPathEffect::SkDashPathEffect'
1>          C:\DEV\3rd_party_sources\skia\include\effects\SkDashPathEffect.h(17) : see declaration of 'SkDashPathEffect'
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(263): error C2248: 'SkDashPathEffect::SkDashPathEffect' : cannot access protected member declared in class 'SkDashPathEffect'
1>          C:\DEV\3rd_party_sources\skia\include\effects\SkDashPathEffect.h(62) : see declaration of 'SkDashPathEffect::SkDashPathEffect'
1>          C:\DEV\3rd_party_sources\skia\include\effects\SkDashPathEffect.h(17) : see declaration of 'SkDashPathEffect'
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(274): error C2248: 'SkDashPathEffect::SkDashPathEffect' : cannot access protected member declared in class 'SkDashPathEffect'
1>          C:\DEV\3rd_party_sources\skia\include\effects\SkDashPathEffect.h(62) : see declaration of 'SkDashPathEffect::SkDashPathEffect'
1>          C:\DEV\3rd_party_sources\skia\include\effects\SkDashPathEffect.h(17) : see declaration of 'SkDashPathEffect'
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(287): error C2248: 'SkDashPathEffect::SkDashPathEffect' : cannot access protected member declared in class 'SkDashPathEffect'
1>          C:\DEV\3rd_party_sources\skia\include\effects\SkDashPathEffect.h(62) : see declaration of 'SkDashPathEffect::SkDashPathEffect'
1>          C:\DEV\3rd_party_sources\skia\include\effects\SkDashPathEffect.h(17) : see declaration of 'SkDashPathEffect'
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(369): error C2039: 'kARGB_8888_Config' : is not a member of 'SkBitmap'
1>          C:\DEV\3rd_party_sources\skia\include\core\SkBitmap.h(38) : see declaration of 'SkBitmap'
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(369): error C2065: 'kARGB_8888_Config' : undeclared identifier
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(377): error C2039: 'kARGB_8888_Config' : is not a member of 'SkBitmap'
1>          C:\DEV\3rd_party_sources\skia\include\core\SkBitmap.h(38) : see declaration of 'SkBitmap'
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(377): error C2065: 'kARGB_8888_Config' : undeclared identifier
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(391): error C2039: 'drawBitmapRectToRect' : is not a member of 'SkCanvas'
1>          c:\dev\3rd_party_sources\skia\include\core\SkCanvas.h(55) : see declaration of 'SkCanvas'
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(434): warning C4018: '<' : signed/unsigned mismatch
1>C:\DEV\3rd_party_sources\wt\3.3.4\src\Wt\WRasterImage-skia.C(646): error C2259: 'Wt::RasterStream' : cannot instantiate abstract class
1>          due to following members:
1>          'size_t SkWStream::bytesWritten(void) const' : is abstract
1>          C:\DEV\3rd_party_sources\skia\include\core\SkStream.h(195) : see declaration of 'SkWStream::bytesWritten'
#1

Updated by Wim Dumon over 6 years ago

Hey,

Since skia does (did?) not really do releases, we indeed pinned one particular git version that we use to build our binary windows version against. We build skia git version 394c7b.

Wim.

#2

Updated by Momo LALMI over 6 years ago

Hello Wim,

the git version 394c7b is old and does not build correctly under Windows (didn't try Linux version yet).

Do you have plans to upgrade WT to use the latest skia version ?

BR

#3

Updated by Roel Standaert 27 days ago

  • Description updated (diff)
  • Status changed from New to Closed

Also available in: Atom PDF