Project

General

Profile

Bug #4781

Theme CSS sometimes dropped in widgetset mode with web-sockets true

Added by Bruce Toll almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
03/01/2016
Due date:
% Done:

0%

Estimated time:

Description

In Wt-3.3.5, with web-sockets true, the theme CSS is sometimes not output in widgetset mode. This can be demonstrated with examples/feature/widgetset using a browser to see which stylesheets get loaded. The behavior appears to be browser and timing-dependent. Sometimes both wt.css and webkit-transitions.css are loaded. Other times, only webkit-transitions.css gets loaded. Although the widgetset example does not make much use of wt.css, I believe the erroneous case is when wt.css is not loaded. With Chrome 48.0.2569.116m under Windows 7, wt.css generally does not get loaded (although I've seen it succeed). With Firefox 44.0.2, wt.css always seems to get loaded...

Attached is a patch to WebRenderer.C which seems to help with the issue. It was lightly tested on a branch from 3.3.5-6-g56eecbd, but should apply cleanly to latest github as WebRenderer.C has not changed since then. The patch would definitely benefit from a careful review.


Files

#1

Updated by Koen Deforche almost 6 years ago

  • Status changed from New to InProgress
  • Assignee set to Koen Deforche
#2

Updated by Koen Deforche almost 6 years ago

  • Status changed from InProgress to Resolved
  • Target version set to 3.3.6

Hey, thanks. I've fixed it differently (since in this case actually it was the state of (not) being already rendered() that was misdetected).

#3

Updated by Koen Deforche over 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF