Project

General

Profile

Actions

Bug #628

closed

WGridLayout : Bug : Additional <td> at the left and the right

Added by Anonymous over 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
-
Start date:
12/02/2010
Due date:
% Done:

0%

Estimated time:

Description

It was not the case with older versions of WT

When a WGridLayout is used, two useless columns are inserted (the first on the left of WGridLayout and the second on the right )

Please see attached screenshots for an example.

here, margins are (0,0,0,0)


Files

WgridLayout.png (73.8 KB) WgridLayout.png Anonymous, 12/02/2010 10:57 PM
WgridLayout2.png (143 KB) WgridLayout2.png Anonymous, 12/02/2010 10:57 PM
Actions #1

Updated by Koen Deforche over 13 years ago

  • Assignee set to Koen Deforche

Hey,

Is this version 3.1.7 of Wt ?

That is quite bizarre --- we do not see these extra td's nowhere. Care to reproduce this in a small test-case, or git bisect it down to a commit ?

Regards,

koen

Actions #2

Updated by Momo LALMI over 13 years ago

Hi Koen,

I am Mohamed LALMI, the person who posted the previous request, I was not connected to redmine.

I will try to make a test case.

In my case : (WGridLayout or WVBoxLayout) was inserted into a WContainerWidget, this WContainerWidget was inserted into WStackedWidget which was inserted into WBorderLayout :)

I hope this will help fixing the problem...

The WT version that worked correctly (i.e: without additional < td > in WVBoxLayout ad WGridLayout ) is the one updated on 10-15-2010

thank you in advance for your help.

Actions #3

Updated by Koen Deforche over 13 years ago

Hey,

So, the version of 10-19-2010 fails? Or that is simply the previous version you've used ?

You can check out a particular Wt version using

$ git checkout <sha-id>

You can find sha-id's using git log

Finally, it would be most helpful if you can narrow it down to a specific commit using $git bisect$ ... but that will require some build patience !

I've looked at the diff with that version, and the only thing that changed to layout managers that could affect this is the implementation of rowSpan.

Regards,

koen

Actions #4

Updated by Momo LALMI over 13 years ago

Hello,

this is related to WBorderLayout ( West Item and East Item) that's why the additional

elements appears in the window.

Even if there is no Widget in West region and East region, a space is reserved and displayed on the browser, this may be related only to google chrome. because opera/FF do not display these regions as empty table columns.

Best regards

Actions #5

Updated by Koen Deforche over 13 years ago

  • Status changed from New to InProgress

Hey Mohammed,

Rather than trying to understand why Chrome shows it different than Firefox, I think it's a good idea to make sure that the TD is not shown at all for a border layout if there is no item set.

Regards,

koen

Actions #6

Updated by Koen Deforche about 13 years ago

  • Status changed from InProgress to Resolved

Hey Mohammed,

I've fixed the handling of empty items: their padding is now entirely eliminated, which should hopefully trigger the correct rendering behaviour in Chrome (I couldn't reproduce your original problem).

Regards,

koen

Actions #7

Updated by Koen Deforche about 13 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF