Project

General

Profile

Bug #6293

Regression in 3.3.9 for bug #1947

Added by Velvet Jones over 2 years ago. Updated almost 2 years ago.

Status:
Feedback
Priority:
Normal
Assignee:
Target version:
Start date:
03/15/2018
Due date:
% Done:

0%

Estimated time:

Description

I posted an issue about 5 years ago that was fixed, but I see the original behavior in 3.3.9 now. The issue number is 1947 and includes a test case.


Files

issue_6293.patch (452 Bytes) issue_6293.patch Roel Standaert, 04/11/2018 05:35 PM
fix-6293.patch (5.12 KB) fix-6293.patch new patch attempt Koen Deforche, 05/23/2018 10:56 PM
error.gif (833 KB) error.gif Velvet Jones, 05/24/2018 11:17 AM
main.cpp (1.75 KB) main.cpp Velvet Jones, 05/25/2018 01:37 PM
#2

Updated by Wim Dumon over 2 years ago

  • Target version set to 3.3.10
#3

Updated by Roel Standaert over 2 years ago

So I have a patch that seems to improve things, but I'm not entirely convinced that it's the appropriate solution...

#4

Updated by Velvet Jones over 2 years ago

I've tried the patch, it works - sorta.

My code looks like this:

this~~m_layout>setColumnStretch(0,0);

this
m_layout>setColumnStretch(1,this->m_columnCount > 2 ? 60 : 75);

this
m_layout~~>setColumnStretch(2,this->m_columnCount > 2 ? 40 : 25);

For 3 columns it looks right, but for 2 columns I seem to get 50/50. Tried changing to 80/20 in the code above for 3-columns, but it still shows the exact same size as 75/25.

#5

Updated by Velvet Jones over 2 years ago

Correction: I tried changing to 80/20 for **2* columns, not 3 columns. Result still appears to be a 50/50 split when set to 80/20.

#6

Updated by Roel Standaert over 2 years ago

  • Status changed from New to Feedback

Could you provide some example code for that? When I change your initial example code it seems fine.

#7

Updated by Velvet Jones over 2 years ago

Try this:

Using the existing test harness, simply click on the "Test" tab repeatedly. On my system, the column widths change every time until they "settle".

#8

Updated by Roel Standaert over 2 years ago

  • Target version changed from 3.3.10 to 3.3.11
#9

Updated by Velvet Jones over 2 years ago

Gotta say, I would be eternally grateful if you could get this fixed in 3.3.10. I've been putting off a release because this affects the layout of almost every page in my app.

#10

Updated by Roel Standaert over 2 years ago

I just released 3.3.10. I really couldn't put off its release any longer. I will look further into this, but it should be possible to just apply the fix as a single patch on top of 3.3.10.

#11

Updated by Velvet Jones over 2 years ago

When I apply the patch to the 3.3.10 release, my sub-menus no longer pop up. And then of course it also shows the original behavior with the grid column widths being shifted every time I click the tab, etc.

#12

Updated by Velvet Jones over 2 years ago

Any chance I can get a fix for this problem?

#13

Updated by Roel Standaert over 2 years ago

  • Assignee set to Koen Deforche
#14

Updated by Koen Deforche over 2 years ago

Hey,

Can you try attached patch?

Regards,

koen

#15

Updated by Velvet Jones over 2 years ago

I've tried it, it's close. Instead of updating the test case I have attached a screenshot showing the result behavior after applying the patch. I am simply clicking between multiple tabs, and the screen layout keeps adjusting as I click different tabs. So I end up chasing the tabs around the screen in order to switch between them.

#16

Updated by Koen Deforche over 2 years ago

Hey,

Did you test with or without Roel's patch? Preferably I'ld like to know the result without Roel's patch?

If it still fails: it would be really helpful if the test cases reproduces the issue.

Koen

#17

Updated by Velvet Jones over 2 years ago

I tested without Roel's patch. A git diff shows that the only files changed from the detached head tag 3.3.10 are 'src/js/WtResize.js' and 'src/js/WtResize.min.js'.

I'll add a tab and some various data to the tabs to see if I can get the test case to reproduce.

#18

Updated by Velvet Jones over 2 years ago

I've added a test case that seems to reproduce the problem. When you alternate between clicking the two tabs, the layout shifts each time.

#19

Updated by Roel Standaert about 2 years ago

  • Target version changed from 3.3.11 to 3.3.12
#20

Updated by Roel Standaert almost 2 years ago

  • Target version changed from 3.3.12 to 3.4.0

Also available in: Atom PDF