Project

General

Profile

Actions

Bug #7081

closed

Regression: js error with globalEscapePressed

Added by Bruce Toll almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
06/07/2019
Due date:
% Done:

0%

Estimated time:

Description

There appears to be a regression with github wt 4.0.5-52-ge490cdd9 and globalEscapePressed handling. To demonstrate, visit the widgetgallery page layout/dialogs and click the "Start" button for the third example (Launch phase). Then press escape. You should see a javascript error. On chromium, it looks like this (simplified) for clarity:

Uncaught TypeError: obj.getBoundingClientRect is not a function
    at Object.window.Wt4_1_0.widgetPageCoordinates
    at encodeEvent
    at Object.update
    at f392 (eval at doJavaScript <anonymous>:475:166)
    at HTMLDocument.<anonymous>
Actions #1

Updated by Roel Standaert almost 5 years ago

  • Status changed from New to Resolved

Good catch. obj is the window object in that case. I pushed a fix.

Actions #2

Updated by Bruce Toll almost 5 years ago

Thanks for the quick fix!

Actions #3

Updated by Roel Standaert over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF