http://redmine.emweb.be/http://redmine.emweb.be/favicon.ico?16934085252020-07-09T08:19:10ZRedmineWt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=255822020-07-09T08:19:10ZBruce Toll
<ul></ul><p>I did some additional testing and found a problem with the patch breaking existing code. Specifically, I had a WMenu in a WDialog where it was intended that focus would remain in the WDialog using keyWentDown() to check for arrow keys and switch between menu entries. With the patch, the arrow keys continue to work --- until you click on a menu item. At that point, focus switches and the arrow keys in the parent WDialog no longer respond (but the tab key now does). In any case, the existing code depended on the fact that the menu items could not receive focus (even with a click) and the patch broke that assumption. I suspect this is just one example of the patch having too broad an effect.</p>
<p>So, I'd suggest ignoring the patch in its current state --- although I'm open to any feedback on improving it. In the meantime, I think that using CSS "user-select:none" will provide a more targeted approach to preventing anchor text from being selected and it can be implemented outside the library in user code.</p>
Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=256442020-07-31T07:51:23ZRoel Standaertroel@emweb.be
<ul><li><strong>Target version</strong> set to <i>4.5.0</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=266572020-11-23T13:57:19ZRoel Standaertroel@emweb.be
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/26657/diff?detail_id=25690">diff</a>)</li><li><strong>Target version</strong> changed from <i>4.5.0</i> to <i>4.6.0</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=312772021-06-02T19:45:22ZRoel Standaertroel@emweb.be
<ul><li><strong>Target version</strong> changed from <i>4.6.0</i> to <i>future</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=373402021-12-09T15:53:08ZRoel Standaertroel@emweb.be
<ul><li><strong>Target version</strong> changed from <i>future</i> to <i>4.7.0</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=377222021-12-17T08:22:12ZKorneel Dumonkorneel@emweb.be
<ul></ul><p>I did some testing with having <code>WAnchor</code> render as a <code><button></code> when it has no link. For the styling, I added <code>btn btn-link</code>. In bootstrap 3 this looks similar but not quite there since the style sheets rely on the <code><a></code> tag in the context of these navigation buttons. In bootstrap 5, it works nicely since they rely on style class <code>nav-link</code>.</p>
<p>Apart from the bootstrap 3 issue, I also found it conceptually a bit weird to render <code>WAnchor</code> as <code><button></code> (it is also documented to render as <code><a></code>). For these reasons, I am putting this issue aside for now.</p>
Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=405772022-03-10T14:28:02ZRoel Standaertroel@emweb.be
<ul><li><strong>Target version</strong> changed from <i>4.7.0</i> to <i>4.8.0</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=455972022-07-06T12:55:52ZRoel Standaertroel@emweb.be
<ul><li><strong>Target version</strong> changed from <i>4.8.0</i> to <i>4.9.0</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=482352022-10-06T07:54:25ZRoel Standaertroel@emweb.be
<ul><li><strong>Target version</strong> changed from <i>4.9.0</i> to <i>4.10.0</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=538362023-05-30T08:59:01ZMatthias Van Ceulebroeck
<ul><li><strong>Target version</strong> changed from <i>4.10.0</i> to <i>4.10.1</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=547822023-06-23T09:57:53ZMatthias Van Ceulebroeck
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>InProgress</i></li><li><strong>Assignee</strong> set to <i>Matthias Van Ceulebroeck</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=553872023-07-17T13:14:56ZMatthias Van Ceulebroeck
<ul><li><strong>Status</strong> changed from <i>InProgress</i> to <i>Review</i></li></ul><p>It seems correct to implement this without changing the <code>WAnchor</code> to a <code><button></code>, and by setting the <code>href</code> attribute to <code>javascript:void(0);</code>. The breaking of the tab chain in a dialog to me seems expected. The focus changes to a specific item, and as such the handler for another item should not catch the items if the focus changed. Navigating with "tab" seems more correct here.</p>
Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=553882023-07-17T13:15:00ZMatthias Van Ceulebroeck
<ul><li><strong>Assignee</strong> deleted (<del><i>Matthias Van Ceulebroeck</i></del>)</li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=556072023-07-27T13:06:49ZMatthias Van Ceulebroeck
<ul><li><strong>Assignee</strong> set to <i>Korneel Dumon</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=556382023-07-31T10:47:47ZKorneel Dumonkorneel@emweb.be
<ul><li><strong>Status</strong> changed from <i>Review</i> to <i>Implemented @Emweb</i></li><li><strong>Assignee</strong> changed from <i>Korneel Dumon</i> to <i>Matthias Van Ceulebroeck</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=556422023-07-31T12:55:50ZMatthias Van Ceulebroeck
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul> Wt - Bug #7645: Inconsistencies with anchor text selection and inclusion in tab chainhttp://redmine.emweb.be/issues/7645?journal_id=568482023-09-20T14:18:50ZMatthias Van Ceulebroeck
<ul><li><strong>Status</strong> changed from <i>Implemented @Emweb</i> to <i>Closed</i></li></ul>