Bug #8577: test.http reports two failing tests related to trusted proxies - Wt - Redmine

Actions

Copy link

Bug #8577

closed

test.http reports two failing tests related to trusted proxies

Added by Bruce Toll over 2 years ago. Updated almost 2 years ago.

Status:

Closed

Priority:

Low

Assignee:

Roel Standaert

Target version:

4.5.1

Start date:

05/24/2021

Due date:

% Done:

100%

Estimated time:

Description

With Wt 4.5.0-rc1-52-g42a5ef9f (github master), I've encountered two test failures with test.http. It may be a mistake on my part with configuration or how I'm running the tests. I've attached the test output, as well as a patch for your review that helps the tests pass in my environment.

Files

Download all files

test_http_client_address_output_4.5.0-rc1-52-g42a5ef9f.txt (2.93 KB) test_http_client_address_output_4.5.0-rc1-52-g42a5ef9f.txt		Bruce Toll, 05/24/2021 09:09 PM
0001-Fix-a-couple-of-trusted-proxy-tests.patch (1.66 KB) 0001-Fix-a-couple-of-trusted-proxy-tests.patch		Bruce Toll, 05/24/2021 09:09 PM

Actions

Copy link

Updated by Korneel Dumon over 2 years ago

According to the documentation in wt_config.xml, I think it's actually the second test (for Client-IP) that should use the trusted proxy list.

Actions

Copy link

Updated by Bruce Toll over 2 years ago

Hi Korneel,

Thanks for following-up. I think you're right. I probably should have just reported the test failures, as the intended behavior of the tests seemed somewhat ambiguous to me. Please disregard the suggested patch.

--Bruce

Actions

Copy link