Project

General

Profile

Bug #9129

BootstrapVersion::v3 not checked in std::vector<WLinkedCssStyleSheet> WBootstrapTheme::styleSheets() const

Added by Rathnadhar K V over 1 year ago. Updated over 1 year ago.

Status:
Rejected
Priority:
High
Assignee:
-
Target version:
-
Start date:
10/01/2021
Due date:
% Done:

0%

Estimated time:
0.50 h

Description

Namaskara,

In the member function :

std::vector<WLinkedCssStyleSheet> WBootstrapTheme::styleSheets() const

only Bootstrap version 2 is checked when responsive is set.... Bootstrap version 3 is not checked.

if (responsive_) {
    if (version_ == BootstrapVersion::v2)
      result.push_back(WLinkedCssStyleSheet
               (WLink(themeVersionDir.str()
                  + "bootstrap-responsive.css")));

both version 2 and 3 must be checked as :

if((version_ == BootstrapVersion::v2) || ((version_ == BootstrapVersion::v3))
{
   ....
}

Regards
Rathnadhar KV

#1

Updated by Roel Standaert over 1 year ago

  • Status changed from New to Rejected
  • Assignee deleted (Koen Deforche)

No, this is accurate. There is no bootstrap-responsive.css in the case of Bootstrap 3.

Also available in: Atom PDF