Project

General

Profile

Bug #9922

Empty server pushes are not properly discarded

Added by Roel Standaert 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
03/10/2022
Due date:
% Done:

100%

Estimated time:

Description

WebRenderer has an isDirty() function that checks whether there is any update at all. If we have no updates then triggerUpdate() won't actually cause any updates to be pushed.

However, this doesn't work properly. It checks if collectedJS1_ is empty, and we always add an opening and closing curly brace.

A simple fix but somewhat ugly fix could be to update the check from:

!collectedJS1_.empty()

to:

!(collectedJS1_.empty() || (collectedJS1_.length() == 2 && collectedJS1_.str() == "{}"))

Related issues

Related to Bug #10019: Follow up issue for issue #9922: Empty server pushes are not properly discardedClosedRoel Standaert03/11/2022

Actions
#2

Updated by Roel Standaert 8 months ago

  • Status changed from New to InProgress
  • Assignee set to Roel Standaert
#3

Updated by Roel Standaert 8 months ago

  • Status changed from InProgress to Review
  • Assignee deleted (Roel Standaert)
#4

Updated by Roel Standaert 8 months ago

  • Precedes Bug #10019: Follow up issue for issue #9922: Empty server pushes are not properly discarded added
#5

Updated by Roel Standaert 8 months ago

  • Precedes deleted (Bug #10019: Follow up issue for issue #9922: Empty server pushes are not properly discarded)
#6

Updated by Roel Standaert 8 months ago

  • Related to Bug #10019: Follow up issue for issue #9922: Empty server pushes are not properly discarded added
#7

Updated by Roel Standaert 8 months ago

  • Status changed from Review to Resolved
#8

Updated by Roel Standaert 8 months ago

  • % Done changed from 0 to 100
#9

Updated by Roel Standaert 8 months ago

  • Assignee set to Roel Standaert
#10

Updated by Roel Standaert 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF