Project

General

Profile

Actions

Bug #2646

closed

Unrequested WDialog footers after setHidden(false)

Added by Bruce Toll about 10 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
02/09/2014
Due date:
% Done:

0%

Estimated time:

Description

In github version 3.3.1-30-g813a601, unhiding a WDialog with setHidden(false) will add a footer even if it is not requested by the user application. This is more noticeable with the Bootstap(2) theme, since it provides a more visible footer.

This issue can be demonstrated with the qrlogin example. The QR code dialog will have a footer div (though it is hard to notice without looking at the DOM).

The attached patch attempts to address the issue and has been lightly tested. It also attempts to address an apparently similar situation in onDefaultPressed, but that part of the patch has not been tested.

As a note, there appears to be an unrelated WDialog layout issue that is specific to Firefox/Gecko where the full width and height do not seem to be used. I will try to file a separate report for that issue.


Files

Actions #1

Updated by Koen Deforche about 10 years ago

  • Status changed from New to Resolved
  • Assignee set to Koen Deforche
  • Target version set to 3.3.2

Hey Bruce,

Thanks; applied.

Regards,

koen

Actions #2

Updated by Koen Deforche about 10 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF